Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14927
Change subject: IMPALA-6393 live_summary and live_progress are not supported in impalarc ...................................................................... IMPALA-6393 live_summary and live_progress are not supported in impalarc impala_shell main function call function get_config_from_file() to read impalarc file. The function get_config_from_file() save and return the shell options in one dictionary 'shell_options' with the option name as key. impala_shell then update the default option values in 'impala_shell_defaults' with the returned shell options dictionary. But the 'impala_shell_defaults' is defined with option 'dest' as key, instead of option name itself. There are some options for which option name and option dest are different. For example, dest of 'live_summary' is defined as 'print_summary', dest of 'live_progress' is defined as 'print_progress'. This cause option values in impala_shell_defaults are not updated with the values specified in config file if option name and option dest are different. This is the root cause why live_summary and live_progress in impalarc do not take effect in impala_shell. To fix the issue, modify function get_config_from_file() to save the options with 'dest' as key. Add some unit-test cases in test_shell_commandline.py and test_shell_interactive.py. Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 --- M bin/rat_exclude_files.txt M shell/option_parser.py A tests/shell/good_impalarc3 A tests/shell/good_impalarc4 A tests/shell/impalarc_with_error2 M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 7 files changed, 96 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/14927/1 -- To view, visit http://gerrit.cloudera.org:8080/14927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
