Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14927 )
Change subject: IMPALA-6393 live_summary and live_progress are not supported in impalarc ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14927/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14927/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-6393 live_summary and live_progress are not supported in impalarc IMPALA-6393: Add support for live_summary and live_progress in impalarc http://gerrit.cloudera.org:8080/#/c/14927/3//COMMIT_MSG@9 PS3, Line 9: The internal variables for live_summary and live_progress are defined as print_summary : and print_progress in impala_shell. When reading configuration parameters from the : config file, it save configurations as dictionary with external name as key. : This cause live_summary and live_progress in impalarc do not take effect in impala_shell. : : To fix the issue, change internal variable names same as external names for option : live_summary and live_progress. : : Unit test: : 1) manually verified live_summary and live_progress are supported in impalarc : 2) add some unit-test cases in test_shell_commandline.py and test_shell_interactive.py : for option live_summary and live_progress read from impalarc. : 3) passed all test cases for tests/shell/test_shell_interactive.py and : tests/shell/test_shell_commandline.py we dont really need implementation details in the commit message unless something really important needs to be pointed out. You can just write: This patch adds support for live_summary and live_progress in impalarc. Testing: Added tests to test_shell_commandline.py Successfully ran all other tests in test_shell_interactive.py and test_shell_commandline.py http://gerrit.cloudera.org:8080/#/c/14927/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14927/3/tests/shell/test_shell_interactive.py@500 PS3, Line 500: def test_live_option_configuration(self, vector): : """Test the optional configuration file with live_progress and live_summary.""" : # Positive tests : # set live_summary and live_progress as True with config file : rcfile_path = os.path.join(QUERY_FILE_PATH, 'good_impalarc3') : args = ['--config_file=%s' % rcfile_path] : cmds = "set all;" : result = run_impala_shell_interactive(vector, cmds, shell_args=args) : assert 'WARNING:' not in result.stderr, \ : "A valid config file should not trigger any warning: {0}".format(result.stderr) : assert "\tLIVE_SUMMARY: True" in result.stdout : assert "\tLIVE_PROGRESS: True" in result.stdout : : # set live_summary and live_progress as False with config file : rcfile_path = os.path.join(QUERY_FILE_PATH, 'good_impalarc4') : args = ['--config_file=%s' % rcfile_path] : result = run_impala_shell_interactive(vector, cmds, shell_args=args) : assert 'WARNING:' not in result.stderr, \ : "A valid config file should not trigger any warning: {0}".format(result.stderr) : assert "\tLIVE_SUMMARY: False" in result.stdout : assert "\tLIVE_PROGRESS: False" in result.stdout : # override options in config file through command line arguments : args = ['--live_progress', '--live_summary', '--config_file=%s' % rcfile_path] : result = run_impala_shell_interactive(vector, cmds, shell_args=args) : assert "\tLIVE_SUMMARY: True" in result.stdout : assert "\tLIVE_PROGRESS: True" in result.stdout I think we can skip the interactive tests and confirm that the values are being set properly in the test_shell_commandline. Also include this case there "override options in config file through command line arguments" -- To view, visit http://gerrit.cloudera.org:8080/14927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 15 Jan 2020 23:00:01 +0000 Gerrit-HasComments: Yes
