Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14927 )
Change subject: IMPALA-6393 Add support for live_summary and live_progress in impalarc ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14927/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14927/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-6393 Add support for live_summary and live_progress in impalarc nit: add a colon here like IMPALA-6393: Add support for live_summary and live_progress in impalarc http://gerrit.cloudera.org:8080/#/c/14927/4//COMMIT_MSG@12 PS4, Line 12: 1) Added unit-test cases in test_shell_commandline.py and test_shell_interactive.py : for live_summary and live_progress. : 2) Successfully ran all other tests in test_shell_interactive.py and test_shell_commandline.py nit: can you please wrap text for commit messages at 73 characters. (notice the vertical yellow line) -- To view, visit http://gerrit.cloudera.org:8080/14927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4549b775a7966ad89d661d0349cc78754e13a86 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Jan 2020 19:32:54 +0000 Gerrit-HasComments: Yes
