Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 )
Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15103/1/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15103/1/be/src/exec/hdfs-orc-scanner.cc@203 PS1, Line 203: root_type->toString(), filename()); > Yes, added an error code. I see, thanks for the clarification! http://gerrit.cloudera.org:8080/#/c/15103/1/testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test File testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test: http://gerrit.cloudera.org:8080/#/c/15103/1/testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test@172 PS1, Line 172: ==== > Yes, they can be ommitted if the expected string is not a regex. Substring Great to know, thanks! I'm okay if you leave it that way, as you find it best. -- To view, visit http://gerrit.cloudera.org:8080/15103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I452d27b4e281eada00b62ac58af773a3479163ec Gerrit-Change-Number: 15103 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2020 10:36:07 +0000 Gerrit-HasComments: Yes
