Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 )
Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15103/5/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/15103/5/be/src/exec/orc-metadata-utils.cc@45 PS5, Line 45: nit: too much indentation http://gerrit.cloudera.org:8080/#/c/15103/5/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/15103/5/tests/query_test/test_scanners.py@1337 PS5, Line 1337: # Create a table whose nested types don't match the underlying ORC files. : # Reuse the data files of functional_orc_def.complextypestbl. : complex_types_loc = get_fs_path("/test-warehouse/complextypestbl_orc_def") : self.client.execute("""create external table %s.ill_complextypes2 (id bigint, : int_array map<string, int>, : int_array_array array<struct<x:int>>, : int_map array<struct<k:string,v:int>>, : int_map_array array<array<struct<k:string,v:int>>> : ) stored as orc location '%s'""" % (unique_database, complex_types_loc)) Can it be moved to orc-type-checks.test? -- To view, visit http://gerrit.cloudera.org:8080/15103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I452d27b4e281eada00b62ac58af773a3479163ec Gerrit-Change-Number: 15103 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2020 14:10:13 +0000 Gerrit-HasComments: Yes
