Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 )
Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.h File be/src/runtime/io/data-cache.h: http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.h@327 PS1, Line 327: bool HandleExistingEntry(const kudu::Slice& key, const kudu::Cache::UniqueHandle& handle, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@446 PS1, Line 446: meta_cache_(kudu::NewCache<kudu::Cache::EvictionPolicy::LRU, kudu::Cache::MemoryType::DRAM>(capacity_, path_)) { line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@553 PS1, Line 553: kudu::Cache::UniqueHandle handle(meta_cache_->Lookup(key, kudu::Cache::EXPECT_IN_CACHE)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@611 PS1, Line 611: kudu::Cache::UniquePendingHandle pending_handle(meta_cache_->Allocate(key, sizeof(CacheEntry), charge_len)); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@643 PS1, Line 643: kudu::Cache::UniqueHandle handle(meta_cache_->Lookup(key, kudu::Cache::EXPECT_IN_CACHE)); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Jan 2020 16:57:22 +0000 Gerrit-HasComments: Yes
