Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 )
Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile ...................................................................... Patch Set 2: (1 comment) I think I'm ready to +2 unless someone else wants to review. http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@558 PS2, Line 558: handle.get() > I know. I prefer doing it this way because it makes it more obvious to read UniqueHandle is a bit weird, because it is a unique_ptr without exposing that fact in the type name. I looked through the Kudu codebase, and they always wrap the UniqueHandle in something else. I don't feel too strongly, so let's leave it this way. -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Feb 2020 17:13:25 +0000 Gerrit-HasComments: Yes