Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 )
Change subject: IMPALA-4224: execute separate join builds fragments ...................................................................... Patch Set 35: (6 comments) I focused on the backend. It looks good to me, although I still need to go over the resource management part to really understand all moving parts. http://gerrit.cloudera.org:8080/#/c/14859/35//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14859/35//COMMIT_MSG@38 PS35, Line 38: accordingly. Something lost between edits. http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/blocking-join-node.h File be/src/exec/blocking-join-node.h: http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/blocking-join-node.h@63 PS35, Line 63: separate build fragment nit: maybe "separate but co-located build fragment"? I feel it's worth to emphasize that it runs in the same process but in a different thread. http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/blocking-join-node.cc File be/src/exec/blocking-join-node.cc: http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/blocking-join-node.cc@196 PS35, Line 196: if (!open_called_) { nit: maybe an early return would make it a bit more readable http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/join-builder.h File be/src/exec/join-builder.h: http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/join-builder.h@54 PS35, Line 54: class JoinBuilder : public DataSink { Maybe you could add a timeline, or sequence diagram-like thingy about the interaction between the BlockingJoinNode and the JoinBuilder. http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/join-builder.cc File be/src/exec/join-builder.cc: http://gerrit.cloudera.org:8080/#/c/14859/35/be/src/exec/join-builder.cc@90 PS35, Line 90: HandoffToProbe nit: HandoffToProbes (plural)? http://gerrit.cloudera.org:8080/#/c/14859/32/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/14859/32/common/thrift/PlanNodes.thrift@617 PS32, Line 617: 28 > I did this mainly to reduce the size of the diff. I think I'd prefer to kee No, I also don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/14859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4403c8e62d9c13854e7830602ee613f8efc80c58 Gerrit-Change-Number: 14859 Gerrit-PatchSet: 35 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Feb 2020 17:27:50 +0000 Gerrit-HasComments: Yes
