Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14859 )
Change subject: IMPALA-4224: execute separate join builds fragments ...................................................................... Patch Set 35: (6 comments) http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@272 PS35, Line 272: maxRowBufferSize + bufferSize Don't we need to multiply by 2? Or is it because the probe will also use the builder's buffers? http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@305 PS35, Line 305: Data sinks nit: Build sinks? http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/Planner.java@115 PS35, Line 115: createDistributedPlan AFAICT it can still return single-node plans, so why the name change? http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/Planner.java@128 PS35, Line 128: // MT_DOP > 0 is not supported by default for plans with base table joins or table : // sinks: we only allow MT_DOP > 0 with such plans if --unlock_mt_dop=true is : // specified. We allow single node plans with mt_dop since there is no actual : // parallelism. nit: maybe the comment should placed in useParallelPlan() since it refers to things that are not visible here anymore (MT_DOP, single node exec) http://gerrit.cloudera.org:8080/#/c/14859/35/fe/src/main/java/org/apache/impala/planner/Planner.java@283 PS35, Line 283: !ctx_.isSingleNodeExec(); Why can't we create a parallel plan on a single node? http://gerrit.cloudera.org:8080/#/c/14859/35/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/14859/35/tests/query_test/test_join_queries.py@35 PS35, Line 35: Would it add coverage if we keep 1 as well? -- To view, visit http://gerrit.cloudera.org:8080/14859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4403c8e62d9c13854e7830602ee613f8efc80c58 Gerrit-Change-Number: 14859 Gerrit-PatchSet: 35 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Feb 2020 13:54:08 +0000 Gerrit-HasComments: Yes
