Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15233 )
Change subject: IMPALA-9036: Fix CTRL+C a multiline query in impala-shell ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15233/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15233/2//COMMIT_MSG@9 PS2, Line 9: `_signal_handler()` nit: instead of backticks please put the function name between single quotes. http://gerrit.cloudera.org:8080/#/c/15233/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/15233/2/shell/impala_shell.py@562 PS2, Line 562: self.prompt = self.cached_prompt Question: Have you tried to simple set both self.prompt and self.cached_prompt to empty string? I don't understand it 100% what cached_prompt holds in this case that we want to reuse. -- To view, visit http://gerrit.cloudera.org:8080/15233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d8bdaee929e2655eb66e886ae92a02d3fbd83f Gerrit-Change-Number: 15233 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2020 08:10:15 +0000 Gerrit-HasComments: Yes
