Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15233 )
Change subject: IMPALA-9036: Fix CTRL+C a multiline query in impala-shell ...................................................................... Patch Set 4: (3 comments) I just left some nits but in general I'm fine with the change. http://gerrit.cloudera.org:8080/#/c/15233/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/15233/4/tests/shell/test_shell_interactive.py@253 PS4, Line 253: doesn't ends nit: doesn't end http://gerrit.cloudera.org:8080/#/c/15233/4/tests/shell/test_shell_interactive.py@258 PS4, Line 258: "select \"test withouth newline\";\n" nit: I think if you put this string between single quotes then you don't need to escape the double quotes inside. This would make it a bit more readable. http://gerrit.cloudera.org:8080/#/c/15233/4/tests/shell/test_shell_interactive.py@271 PS4, Line 271: "select \"test with newline\";\n" nit: same as above -- To view, visit http://gerrit.cloudera.org:8080/15233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d8bdaee929e2655eb66e886ae92a02d3fbd83f Gerrit-Change-Number: 15233 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Feb 2020 21:10:41 +0000 Gerrit-HasComments: Yes
