Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: WIP: Asynchronous code generation ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/15105/19/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/15105/19/be/src/exec/partitioned-hash-join-builder.cc@659 PS19, Line 659: int PhjBuilder::GetNumSpilledPartitions(const vector<unique_ptr<PhjBuilderPartition>>& partitions) { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/15105/19/be/src/exec/partitioned-hash-join-builder.cc@979 PS19, Line 979: PhjBuilderPartition::PhjBuilderPartition(RuntimeState* state, PhjBuilder* parent, int level) line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 19 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2020 10:31:45 +0000 Gerrit-HasComments: Yes
