Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: WIP: Asynchronous code generation ...................................................................... Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/15105/23/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/15105/23/be/src/exec/partitioned-hash-join-builder.h@680 PS23, Line 680: std::deque<std::unique_ptr<PhjBuilderPartition>>* output_partitions, RowBatch* batch); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15105/23/be/src/exec/partitioned-hash-join-builder.h@685 PS23, Line 685: std::deque<std::unique_ptr<PhjBuilderPartition>>* output_partitions, RowBatch* batch); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15105/23/be/src/exec/partitioned-hash-join-builder.h@866 PS23, Line 866: const CodegenFnPtr<PhjBuilderConfig::ProcessBuildBatchFn>& process_build_batch_fn_level0_; line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 23 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2020 23:44:25 +0000 Gerrit-HasComments: Yes
