Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 3: (11 comments) Address flake comments. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@657 PS3, Line 657: r > flake8: E731 do not assign a lambda expression, use a def I think in this case we need the lazy evaluation which lambda expressions provide and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@685 PS3, Line 685: ; > flake8: E703 statement ends with a semicolon Done. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@715 PS3, Line 715: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@733 PS3, Line 733: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@744 PS3, Line 744: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@812 PS3, Line 812: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@829 PS3, Line 829: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@849 PS3, Line 849: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/shell/impala_client.py@858 PS3, Line 858: r > flake8: E731 do not assign a lambda expression, use a def Need lazy evaluation and so cannot use def. http://gerrit.cloudera.org:8080/#/c/15378/3/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/15378/3/tests/custom_cluster/test_hs2_fault_injection.py@65 PS3, Line 65: / > flake8: E226 missing whitespace around arithmetic operator Done. http://gerrit.cloudera.org:8080/#/c/15378/3/tests/custom_cluster/test_hs2_fault_injection.py@223 PS3, Line 223: > flake8: E211 whitespace before '(' Done. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Mar 2020 23:31:33 +0000 Gerrit-HasComments: Yes
