Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 6: (1 comment) the goal here is to recover from possible connection drops by the server correct? it looks like the patch is currently checking if a RPC fails, and then just retrying it. shouldn't the client try to re-establish the connection to the server first, before trying to issue the RPC retry? http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py@933 PS6, Line 933: _do_hs2_rpc if the goal is to recover from connections that are closed by the server, is there no way to check if the connection is still valid before issuing a request from the client? it looks like self._check_connected() just looks like this check only validates if self.connected has been set to true or false having a better way to check if the server has closed the connection would help with idle connections as well - e.g if an impala-shell user connects, and then steps away from their computer for a while. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Mar 2020 01:01:11 +0000 Gerrit-HasComments: Yes
