Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/15371 )
Change subject: IMPALA-9429: Unioned partition columns break partition pruning ...................................................................... Patch Set 1: (2 comments) Thanks for the insights. http://gerrit.cloudera.org:8080/#/c/15371/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15371/1//COMMIT_MSG@14 PS1, Line 14: surrounding code only handles specific cases. > Could you also explain why the bug doesn't happen in these two cases: I don't think that's quite what happens as the always True cases his the same issue. I'll look more tomorrow at what is happening in each case. http://gerrit.cloudera.org:8080/#/c/15371/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/15371/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1734 PS1, Line 1734: analyzer.getConstantFolder().rewriteList(opConjuncts, analyzer); > I think we don't need to do constant folding each time we substitute predic Adding as a rule works. Also changed to add clonedConjunct to partitionConjuncts instead of the original conjunct. -- To view, visit http://gerrit.cloudera.org:8080/15371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c1384c2cd1ad5f7024449196f9a348ecdccb60b Gerrit-Change-Number: 15371 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 04:46:08 +0000 Gerrit-HasComments: Yes
