Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/15371 )
Change subject: IMPALA-9429: Unioned partition columns break partition pruning ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15371/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/15371/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@134 PS3, Line 134: Expr clonedConjunct = exprRewriter_.rewrite(conjunct.clone(), analyzer); > Should we catch the AnalysisException thrown by FoldConstantsRule (just lik Only if the rules mismatch which we want to know. http://gerrit.cloudera.org:8080/#/c/15371/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@199 PS3, Line 199: expr = analyzer.getConstantFolder().rewrite(expr, analyzer); > Given that we have done constant folding on 'expr' before calling this meth Skipping this optimization for now. http://gerrit.cloudera.org:8080/#/c/15371/3/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@225 PS3, Line 225: analyzer.getConstantFolder().rewrite(expr, analyzer); > Same here. I think we don't need this now. Skipping this optimization for now. -- To view, visit http://gerrit.cloudera.org:8080/15371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c1384c2cd1ad5f7024449196f9a348ecdccb60b Gerrit-Change-Number: 15371 Gerrit-PatchSet: 3 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2020 03:34:13 +0000 Gerrit-HasComments: Yes
