Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 6: (1 comment) Added a test to simulate connection drops between rpcs. http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/15378/6/shell/impala_client.py@933 PS6, Line 933: _do_hs2_rpc > hmm thats interesting, I just assumed it was using HTTP Keep-Alive, but if I was able to test connection drops by killing worker processes in nginx. Re the worker shutdown timeout for nginx ingress controller. The default is 240 seconds which is much more than most rpcs will take. But, I have still seen some connections drop during rpcs. I still need to figure out why the timeout is not being honored. That said connection could also drop after nginx in the proxy. Yeah, i think thats an accurate statement. If the connection drops at the nginx ingress controller then we get an EOF. If it drops at the proxy after nginx then nginx gets a 502/503 error which nginx passes back to client. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Mar 2020 22:52:32 +0000 Gerrit-HasComments: Yes
