Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 )
Change subject: WIP: Asynchronous code generation ...................................................................... Patch Set 26: (21 comments) http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py File tests/query_test/test_async_codegen.py: http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@19 PS26, Line 19: from copy import copy flake8: F401 'copy.copy' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@21 PS26, Line 21: from tests.beeswax.impala_beeswax import ImpalaBeeswaxException flake8: F401 'tests.beeswax.impala_beeswax.ImpalaBeeswaxException' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@22 PS26, Line 22: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.create_parquet_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@22 PS26, Line 22: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.create_avro_snappy_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@26 PS26, Line 26: from tests.common.impala_cluster import ImpalaCluster flake8: F401 'tests.common.impala_cluster.ImpalaCluster' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@28 PS26, Line 28: from tests.common.skip import SkipIfNotHdfsMinicluster flake8: F401 'tests.common.skip.SkipIfNotHdfsMinicluster' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@29 PS26, Line 29: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.extend_exec_option_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@32 PS26, Line 32: from tests.common.test_vector import ImpalaTestDimension flake8: F401 'tests.common.test_vector.ImpalaTestDimension' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@33 PS26, Line 33: from tests.verifiers.metric_verifier import MetricVerifier flake8: F401 'tests.verifiers.metric_verifier.MetricVerifier' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@36 PS26, Line 36: from RuntimeProfile.ttypes import TRuntimeProfileFormat flake8: F401 'RuntimeProfile.ttypes.TRuntimeProfileFormat' imported but unused http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@38 PS26, Line 38: class TestAsyncCodegen(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@79 PS26, Line 79: ) flake8: E123 closing bracket does not match indentation of opening bracket's line http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@87 PS26, Line 87: = flake8: E712 comparison to False should be 'if cond is False:' or 'if not cond:' http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@93 PS26, Line 93: ) flake8: E123 closing bracket does not match indentation of opening bracket's line http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@106 PS26, Line 106: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@106 PS26, Line 106: n flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@108 PS26, Line 108: c flake8: F841 local variable 'codegen_start' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@120 PS26, Line 120: a flake8: F631 assertion is always true, perhaps remove parentheses? http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@155 PS26, Line 155: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@157 PS26, Line 157: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/15105/26/tests/query_test/test_async_codegen.py@158 PS26, Line 158: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/15105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7cbfa7c6734dcf03641629429057d6a4194aa6b Gerrit-Change-Number: 15105 Gerrit-PatchSet: 26 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 02:40:03 +0000 Gerrit-HasComments: Yes
