Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15818 )
Change subject: IMPALA-9512: Full ACID Milestone 2: Validate each row against the valid write id list ...................................................................... Patch Set 1: (22 comments) http://gerrit.cloudera.org:8080/#/c/15818/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/15818/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java@442 PS1, Line 442: if (writeIds.isWriteIdRangeValid(current + 1, next.maxWriteId) != ValidWriteIdList.RangeResponse.NONE) { line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py File tests/common/acid_txn.py: http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@19 PS1, Line 19: from hive_metastore import * flake8: F403 'from hive_metastore import *' used; unable to detect undefined names http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@20 PS1, Line 20: from hive_metastore.ttypes import * flake8: F403 'from hive_metastore.ttypes import *' used; unable to detect undefined names http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@53 PS1, Line 53: T flake8: F405 'ThriftHiveMetastore' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@66 PS1, Line 66: O flake8: F405 'OpenTxnRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@74 PS1, Line 74: A flake8: F405 'AllocateTableWriteIdsRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@82 PS1, Line 82: G flake8: F405 'GetValidWriteIdsRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@87 PS1, Line 87: S flake8: F405 'ShowLocksRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@94 PS1, Line 94: L flake8: F405 'LockType' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@95 PS1, Line 95: L flake8: F405 'LockLevel' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@96 PS1, Line 96: L flake8: F405 'LockComponent' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@101 PS1, Line 101: L flake8: F405 'LockRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@109 PS1, Line 109: C flake8: F405 'CheckLockRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@114 PS1, Line 114: U flake8: F405 'UnlockRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@119 PS1, Line 119: H flake8: F405 'HeartbeatRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@125 PS1, Line 125: C flake8: F405 'CommitTxnRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@130 PS1, Line 130: A flake8: F405 'AbortTxnRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/common/acid_txn.py@135 PS1, Line 135: T flake8: F405 'TruncateTableRequest' may be undefined, or defined from star imports: hive_metastore, hive_metastore.ttypes http://gerrit.cloudera.org:8080/#/c/15818/1/tests/query_test/test_acid_row_validation.py File tests/query_test/test_acid_row_validation.py: http://gerrit.cloudera.org:8080/#/c/15818/1/tests/query_test/test_acid_row_validation.py@20 PS1, Line 20: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/15818/1/tests/query_test/test_acid_row_validation.py@25 PS1, Line 25: from tests.common.skip import (SkipIfHive2, SkipIfCatalogV2, SkipIfS3, SkipIfABFS, flake8: F401 'tests.common.skip.SkipIfCatalogV2' imported but unused http://gerrit.cloudera.org:8080/#/c/15818/1/tests/query_test/test_acid_row_validation.py@28 PS1, Line 28: from tests.common.test_dimensions import create_single_exec_option_dimension flake8: F401 'tests.common.test_dimensions.create_single_exec_option_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/15818/1/tests/query_test/test_acid_row_validation.py@116 PS1, Line 116: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/15818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d Gerrit-Change-Number: 15818 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Apr 2020 16:59:40 +0000 Gerrit-HasComments: Yes
