Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15818 )

Change subject: IMPALA-9512: Full ACID Milestone 2: Validate rows against the 
valid write id list
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15818/3/tests/query_test/test_acid_row_validation.py
File tests/query_test/test_acid_row_validation.py:

http://gerrit.cloudera.org:8080/#/c/15818/3/tests/query_test/test_acid_row_validation.py@27
PS3, Line 27: class TestAcidRowValidation(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/15818/3/tests/query_test/test_acid_row_validation.py@57
PS3, Line 57: w
flake8: F841 local variable 'write_id' is assigned to but never used


http://gerrit.cloudera.org:8080/#/c/15818/3/tests/query_test/test_acid_row_validation.py@72
PS3, Line 72:
flake8: W391 blank line at end of file


http://gerrit.cloudera.org:8080/#/c/15818/3/tests/util/acid_txn.py
File tests/util/acid_txn.py:

http://gerrit.cloudera.org:8080/#/c/15818/3/tests/util/acid_txn.py@20
PS3, Line 20: from hive_metastore.ThriftHiveMetastore import Client
flake8: F401 'hive_metastore.ThriftHiveMetastore.Client' imported but unused



--
To view, visit http://gerrit.cloudera.org:8080/15818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed74585a2d73ebbcee763b0545be4412926299d
Gerrit-Change-Number: 15818
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 May 2020 15:04:18 +0000
Gerrit-HasComments: Yes

Reply via email to