Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml@762 PS3, Line 762: (,4.1.46] Change this to * to ban all versions. If we need netty, then exclusions won't work. http://gerrit.cloudera.org:8080/#/c/15829/3/fe/pom.xml@1386 PS3, Line 1386: <!-- IMPALA-9648: Avoid pulling in netty --> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-hdfs</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-distcp</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <dependency> : <groupId>org.apache.hadoop</groupId> : <artifactId>hadoop-common</artifactId> : <exclusions> : <exclusion> : <groupId>io.netty</groupId> : <artifactId>*</artifactId> : </exclusion> : </exclusions> : </dependency> : <!-- end IMPALA-9648 --> > If I remove this code block, and build locally, I get this failure: The check job posted a comment on this gerrit review. It did a build and that failed: https://jenkins.impala.io/job/gerrit-code-review-checks/5900/ https://jenkins.impala.io/job/ubuntu-16.04-build-only/11104/ It fails hitting the ban on netty, exactly like you posted (except that it is testing with this code). That's why I thought it was ineffective. After trying it out, I'm reasonably convinced that this dependencyManagement section would be effective, but we must still be missing a location. However, this is entirely doable using normal exclusions. We don't need dependencyManagement for this, so please use normal exclusions. Change the ban so that it is not version dependent, then do this: 0. Add ban and do an initial build 1. Run mvn dependency:tree 2. If it contains netty artifacts, follow the path in the tree up to the artifact we declare in our pom.xml. Ignore the intermediaries, only look at the top level artifact. Add an exclusion there. Goto 1. 3. If there is no netty, run a build and it should be ok. The reason that I prefer normal exclusions is because everything is all in one place. No one has to understand an extra layer of exclusions that reside in a different location from the other exclusions. Also, with normal exclusions, we don't need references to artifacts we don't use (e.g. hadoop-distcp). We still include USE_CDP_HIVE=false as a build in the build-all-options job, so we should do the same process with "export USE_CDP_HIVE=false" in bin/impala-config-local.sh (with new shells). -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Apr 2020 03:38:32 +0000 Gerrit-HasComments: Yes
