David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15829 )
Change subject: IMPALA-9648: Exclude/ban netty-all from mvn download ...................................................................... Patch Set 3: > Patch Set 3: > > My review bandwidth is limited. My suggestion is to start from scratch and > follow the steps I laid out in my comments. If that doesn't work, I can post > my solution. I understand. I'm sorry to take up too much of your time. If you can post your solution, that would be great. I've tried to follow your steps (which I had done before), and it still doesn't work for me. Excluding netty* from hadoop doesn't seem to be an issue, but I can't seem to make this work for hive. At my last iteration, builds are still failing: # with USE_CDP_HIVE=false Found Banned Dependency: io.netty:netty-all:jar:4.1.42.Final # with USE_CDP_HIVE=false Found Banned Dependency: io.netty:netty-all:jar:4.1.17.Final The last output of mvn dependency:tree looks like this: [INFO] +- org.apache.hive:hive-jdbc:jar:3.1.3000.7.1.1.0-380:test [INFO] | +- org.apache.hive:hive-common:jar:3.1.3000.7.1.1.0-380:test [INFO] | | +- org.apache.hive:hive-classification:jar:3.1.3000.7.1.1.0-380:test [INFO] | | +- jline:jline:jar:2.12:compile [INFO] | | +- joda-time:joda-time:jar:2.9.9:test [INFO] | | +- org.apache.logging.log4j:log4j-web:jar:2.10.0:test [INFO] | | | +- org.apache.logging.log4j:log4j-api:jar:2.10.0:test [INFO] | | | \- org.apache.logging.log4j:log4j-core:jar:2.10.0:test [INFO] | | +- net.sf.jpam:jpam:jar:1.1:test [INFO] | | \- com.tdunning:json:jar:1.8:test [INFO] | +- org.apache.hive:hive-service:jar:3.1.3000.7.1.1.0-380:test [INFO] | | +- org.apache.hive:hive-llap-server:jar:3.1.3000.7.1.1.0-380:test [INFO] | | | +- org.apache.hive:hive-llap-common:jar:3.1.3000.7.1.1.0-380:test [INFO] | | | +- org.apache.hive:hive-llap-client:jar:3.1.3000.7.1.1.0-380:test [INFO] | | | | \- org.apache.curator:apache-curator:pom:4.2.0:test [INFO] | | | +- org.apache.hive:hive-llap-tez:jar:3.1.3000.7.1.1.0-380:test [INFO] | | | +- io.netty:netty-all:jar:4.1.17.Final:test <-- I'm stumped I did start with the top level node in the pom (hive-jdbc) as suggested, but netty-all would still show up elsewhere, so I tried the intermediate nodes anyway. By this point in the cycle, I've added an exclusion for every node above that last appearance of netty-all: - org.apache.hive:hive-jdbc - org.apache.hive:hive-common - org.apache.hive:hive-service - org.apache.hive:hive-llap-server (which itself had been excluded elsewhere) Again, sorry this taking so much hand-holding. -- To view, visit http://gerrit.cloudera.org:8080/15829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d61af3c10ee439ca9eef3840403229e6235c97 Gerrit-Change-Number: 15829 Gerrit-PatchSet: 3 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Fri, 01 May 2020 00:40:56 +0000 Gerrit-HasComments: No
