Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15835
Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics ...................................................................... IMPALA-9699: Skip '-1' values when aggregating num_null statistics This change puts back an earlier condition that does not allow negative 'num_null' values to be summarized for the column statistics when incremental stats are used. This helps with the backward compatibility between releases, earlier the default 'num_null' value was '-1' because the number of null values were not supported. The old '-1'values are persisted in the metastore and in case of an upgrade can cause issues without the 'num_new_nulls >= 0' condition. The commit also refactors the PerColumnStats class to make it available from the unit tests. Testing: - Added unit test to verify the accepted values and aggregation result Change-Id: I3fdf48a6c88378145078e068e12ade48c460f956 --- M be/src/exec/incr-stats-util-test.cc M be/src/exec/incr-stats-util.cc M be/src/exec/incr-stats-util.h 3 files changed, 101 insertions(+), 71 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/15835/2 -- To view, visit http://gerrit.cloudera.org:8080/15835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3fdf48a6c88378145078e068e12ade48c460f956 Gerrit-Change-Number: 15835 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
