Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15835 )
Change subject: IMPALA-9699: Skip '-1' values when aggregating num_null statistics ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15835/3/be/src/exec/incr-stats-util.cc File be/src/exec/incr-stats-util.cc: http://gerrit.cloudera.org:8080/#/c/15835/3/be/src/exec/incr-stats-util.cc@128 PS3, Line 128: if (num_new_nulls >= 0) num_nulls += num_new_nulls; I am not 100% sure which is better, but I would prefer to set num_nulls to -1 if num_new_nulls is -1 (+ don't do anything if it is already -1) http://gerrit.cloudera.org:8080/#/c/15835/3/be/src/exec/incr-stats-util.cc@130 PS3, Line 130: avg_width += (new_avg_width * num_new_rows); This is not new code, but it looks very wrong - there is a member called total_width, but it is never used. It makes more sense to use that as an accumulator. -- To view, visit http://gerrit.cloudera.org:8080/15835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fdf48a6c88378145078e068e12ade48c460f956 Gerrit-Change-Number: 15835 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Apr 2020 16:49:54 +0000 Gerrit-HasComments: Yes
