Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 )
Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions ...................................................................... Patch Set 3: (1 comment) LGTM with one non-critical potential improvement. http://gerrit.cloudera.org:8080/#/c/16073/3/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/16073/3/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@285 PS3, Line 285: (inType.isVarchar() || inType.getPrimitiveType() == PrimitiveType.STRING)) { Is it overkill to cover the case of a big truncation? i.e. inType length <<< type length. Hard to reason about the memory benefit though the CPU cost would be low. -- To view, visit http://gerrit.cloudera.org:8080/16073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f1a16fc45191a2eedf38cc243c70173d44806c6 Gerrit-Change-Number: 16073 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jun 2020 00:34:54 +0000 Gerrit-HasComments: Yes
