Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 )
Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16073/3/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/16073/3/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@285 PS3, Line 285: (inType.isVarchar() || inType.getPrimitiveType() == PrimitiveType.STRING)) { > I think that would be a separate case in SortInfo.getMaterializedSortExprs( It is a weird pattern, I'd expect lpad or substr to be used more often, but I did some query searching and using casts to truncate like this does happen, probably some hold over from older SQL behavior. Not critical to address. -- To view, visit http://gerrit.cloudera.org:8080/16073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f1a16fc45191a2eedf38cc243c70173d44806c6 Gerrit-Change-Number: 16073 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jun 2020 03:25:35 +0000 Gerrit-HasComments: Yes
