Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 )
Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used ...................................................................... Patch Set 5: hmm I thought core tests were passing, but I guess not. I fixed the test failures and re-ran core tests and they are clean now. One un-foreseen consequence of adding the SQL-style comments to FunctionCallExpr#toSqlImpl, is that they show up in error messages as well (see the example in the commit message). This might actually be kinda nice, because it makes the error message more informative, but wanted to specifically call this out because I never intended this to happen. -- To view, visit http://gerrit.cloudera.org:8080/16188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79122e6cc74fd5a62c76962289a1615fbac2f345 Gerrit-Change-Number: 16188 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Jul 2020 17:03:26 +0000 Gerrit-HasComments: No
