Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 )
Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used ...................................................................... Patch Set 5: (2 comments) > Did you run exhaustive tests? Would be good to do that just to be sure > nothing else needs to be updated. Ran exhaustive tests, everything passed. http://gerrit.cloudera.org:8080/#/c/16188/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/16188/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@222 PS5, Line 222: if (fn_ != null && !fnName_.isBuiltin()) { > We do have the ToSqlOptions that could maybe control this to hide it in err yeah using ToSqlOptions makes sense, I briefly looked into it but it didn't seem that straightforward because ToSql is called in so many places. http://gerrit.cloudera.org:8080/#/c/16188/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@491 PS5, Line 491: "User Defined Functions (UDFs)" > I wonder if it worth the effort to make the key more explicit: Yeah that would be nice because it makes it consistent with the info from toSql, unfortunately the info about whether it is a native vs. java udf is only available in the fn_ instance variable, which isn't set until the end of the function. it's probably do-able, but maybe not worth the effort since the same info is in the explain plan already. -- To view, visit http://gerrit.cloudera.org:8080/16188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79122e6cc74fd5a62c76962289a1615fbac2f345 Gerrit-Change-Number: 16188 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Jul 2020 19:04:34 +0000 Gerrit-HasComments: Yes
