Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 )
Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator ...................................................................... Patch Set 12: (1 comment) One more test ask related to the computeStats thing and then I'm good http://gerrit.cloudera.org:8080/#/c/16219/11/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/16219/11/fe/src/main/java/org/apache/impala/planner/SortNode.java@143 PS11, Line 143: computeStats(analyzer); > Makes sense. Added. I think some of the planner test output might need to be refreshed, I see some cases where the cardinality is higher than the limit, e.g. in https://gerrit.cloudera.org/#/c/16219/12/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-analytic.test It'd be good to have a regression test too for one case of this to make sure that the memory estimates, etc are right, maybe in resource-requirements.test -- To view, visit http://gerrit.cloudera.org:8080/16219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f46a7bb75a34466eef7f91ddc25b6e6c99284 Gerrit-Change-Number: 16219 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Jul 2020 18:05:57 +0000 Gerrit-HasComments: Yes
