Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16219 )
Change subject: IMPALA-9983 : Pushdown limit to analytic sort operator ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/16219/11/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/16219/11/fe/src/main/java/org/apache/impala/planner/SortNode.java@143 PS11, Line 143: computeStats(analyzer); > I think some of the planner test output might need to be refreshed, I see s Yes, I noticed that too when adding a new test for the flipped predicate..it refreshed the cardinality estimates of the analytic top-n for all other tests. I do realize another issue..the parent operators cardinality estimates did not change. I need to call computeStats() on the ancestor nodes as well after limit pushdown. This should be easy since I keep track of the ancestors during pushdown. I will also add a test to resource-requirements.test. -- To view, visit http://gerrit.cloudera.org:8080/16219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f46a7bb75a34466eef7f91ddc25b6e6c99284 Gerrit-Change-Number: 16219 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Jul 2020 18:17:47 +0000 Gerrit-HasComments: Yes
