Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 )
Change subject: IMPALA-10018: Implement ds_kll_rank() function ...................................................................... Patch Set 1: (1 comment) Hi Gabor, Thank you for the good work with the KLL functions. Apart from a general nit, it looks good to me. http://gerrit.cloudera.org:8080/#/c/16283/1/be/src/exprs/datasketches-functions.h File be/src/exprs/datasketches-functions.h: http://gerrit.cloudera.org:8080/#/c/16283/1/be/src/exprs/datasketches-functions.h@47 PS1, Line 47: not then nit: missing comma As far as I see, it is missing in every comment where this sentence is used. -- To view, visit http://gerrit.cloudera.org:8080/16283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95857886dfbb8c84aeeaf718c0e610012fda4be0 Gerrit-Change-Number: 16283 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Aug 2020 08:39:11 +0000 Gerrit-HasComments: Yes
