Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 )
Change subject: IMPALA-10018: Implement ds_kll_rank() function ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16283/2/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16283/2/be/src/exprs/datasketches-functions-ir.cc@70 PS2, Line 70: return sketch.get_rank(probe_value.val); > A try-catch block could be added to be sure. get_rank() doesn't throw, no need for a try-catch block. https://github.com/apache/impala/blob/master/be/src/thirdparty/datasketches/kll_sketch_impl.hpp#L313 -- To view, visit http://gerrit.cloudera.org:8080/16283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95857886dfbb8c84aeeaf718c0e610012fda4be0 Gerrit-Change-Number: 16283 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Aug 2020 06:23:57 +0000 Gerrit-HasComments: Yes
