Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 )
Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state ...................................................................... Patch Set 2: (1 comment) Thanks for the prompt review! http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc@99 PS1, Line 99: If fetch() is called but nothing was fetched (e.g. due to : // ClientRequestState::FetchRows() timeout > is this change necessary? fetched_rows is only set after WaitForResults ret I think we need this. WaitForResults() returns after the coordinator fragment instance finishes Open(). It doens't mean some results are ready to be fetched. The first timed_out check in FetchInternal() is about WaitForResults(). We then set the fetched_rows_ flag. The real timeout can happen in the following ClientRequestState::FetchRows(). Then the client still fetches nothing and will trigger another fetch() request. As the comment of fetched_rows_ said, it means whether a fetch was attempted by a client, regardless of whether a result set (or error) was returned to the client. So I think we should use num_rows_fetched_ instead. -- To view, visit http://gerrit.cloudera.org:8080/16351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d82bf80640760a47325833463def8a3791bdda Gerrit-Change-Number: 16351 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Aug 2020 01:21:01 +0000 Gerrit-HasComments: Yes
