Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16351 )
Change subject: IMPALA-10065: Fix DCHECK when retrying a query in FINISHED state ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16351/1/be/src/runtime/query-driver.cc@99 PS1, Line 99: : if (client_request_state->fetched_rows()) > > > I think we need this. WaitForResults() returns after the coordinator fr After some offline discussion, we agree that this is complex that we need more time to sort out some race issues. Since this is not required by this patch, created IMPALA-10114 to follow it up. -- To view, visit http://gerrit.cloudera.org:8080/16351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d82bf80640760a47325833463def8a3791bdda Gerrit-Change-Number: 16351 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Aug 2020 04:11:37 +0000 Gerrit-HasComments: Yes