Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 )
Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16369/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16369/2/be/src/scheduling/admission-controller.cc@1218 PS2, Line 1218: const ExecutorGroup* schedule_executor_group = : ExecutorGroup::GetOrCreateExecutorGroup( : executor_group, request.blacklisted_backend_ids); > RemoveExecutors() use ip_address to find executor with map. For the new fun perhaps a simpler way would be for the blacklisted_backend_ids to be an unordered_set of 'const NetworkAddressPB&' instead. then you could use a combination of ExecutorGroup::LookUpBackendDesc and ExecutorGroup::RemoveExecutor to remove executors. this is probably a faster approach as well since its all hash-based lookups and avoids iterating over all the full list of executors (looks like GetOrCreateExecutorGroup already iterates over all executors twice). the other advantage is that it keeps the code simpler since we can now rely on existing methods. http://gerrit.cloudera.org:8080/#/c/16369/2/be/src/scheduling/admission-controller.cc@1232 PS2, Line 1232: output_schedules->emplace_back(std::move(group_state), *executor_group); is there any concern with using executor_group here vs. scheduled_executor_group? -- To view, visit http://gerrit.cloudera.org:8080/16369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00bc1b5026efbd0670ffbe57bcebc457d34cb105 Gerrit-Change-Number: 16369 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Sep 2020 16:39:11 +0000 Gerrit-HasComments: Yes
