Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 )
Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes ...................................................................... Patch Set 6: (4 comments) Thanks a lot for the quick reply! http://gerrit.cloudera.org:8080/#/c/16369/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16369/4/be/src/scheduling/admission-controller.cc@1572 PS4, Line 1572: NLIKELY(!ret.ok())) return ret; > We should not handle the case with number of executor as 0 here since a que Done http://gerrit.cloudera.org:8080/#/c/16369/4/be/src/scheduling/admission-controller.cc@1582 PS4, Line 1582: ol admit_from_queue, PoolStats* > It's not used after making schedule so release here. Done http://gerrit.cloudera.org:8080/#/c/16369/4/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/16369/4/tests/custom_cluster/test_query_retries.py@302 PS4, Line 302: Add admission delay > For this test, we have to simulate blacklist timeout. By adding delay here OK. Thanks a lot for the explanation. http://gerrit.cloudera.org:8080/#/c/16369/4/tests/custom_cluster/test_query_retries.py@332 PS4, Line 332: > We cannot simulate all nodes are blacklisted due to RPC failure since coord Actually I think when #executors is 1, the query plan should change to a serial one. I wonder if this can be verified somehow. -- To view, visit http://gerrit.cloudera.org:8080/16369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00bc1b5026efbd0670ffbe57bcebc457d34cb105 Gerrit-Change-Number: 16369 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Sep 2020 19:26:41 +0000 Gerrit-HasComments: Yes
