Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 )
Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h File be/src/util/webserver.h: http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h@160 PS1, Line 160: const bool is_on_nav_bar_; It seems that we need to acquire url_handlers_lock_ in Webserver::GetCommonJson() when accessing url_handlers_. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Sep 2020 16:59:16 +0000 Gerrit-HasComments: Yes
