Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 )
Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc@526 PS2, Line 526: shared_lock<shared_mutex> lock(url_handlers_lock_); It's better to add brackets around line 526 to 538 so that the lock will be released before calling obj.AddMember(). -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Sep 2020 16:47:05 +0000 Gerrit-HasComments: Yes
