Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 )
Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16489/1/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/16489/1/be/src/exec/buffered-plan-root-sink.cc@168 PS1, Line 168: if (!all_results_spooled_.IsSet()) { I think we can just remove the IsSet() check here and elsewhere. The old value is not overwritten by Set() so this is redundant. -- To view, visit http://gerrit.cloudera.org:8080/16489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaba0ed729ef984f9c51347df02e9fb6f90bc71e0 Gerrit-Change-Number: 16489 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2020 18:09:47 +0000 Gerrit-HasComments: Yes
