Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16489 )
Change subject: IMPALA-10183: Fix hitting DCHECK when cancelling a query with result spooling ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16489/1/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/16489/1/be/src/exec/buffered-plan-root-sink.cc@168 PS1, Line 168: MonotonicStopWatch wait_timeout_timer; > Oh yes! Thanks for pointing out this! Also removed the new comment which re Back in my PhD days I spent a bunch of time doing a literature survey on promises and related data types so this is kinda one of my pet topics :). -- To view, visit http://gerrit.cloudera.org:8080/16489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaba0ed729ef984f9c51347df02e9fb6f90bc71e0 Gerrit-Change-Number: 16489 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2020 05:54:14 +0000 Gerrit-HasComments: Yes
