Hello Sahil Takiar, Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16411
to look at the new patch set (#3).
Change subject: IMPALA-9930 (part 1): Initial refactor for admission control
service
......................................................................
IMPALA-9930 (part 1): Initial refactor for admission control service
This patch contains the following refactors that are needed for the
admission control service, in order to make the main patch easier to
review:
- Adds a new class AdmissionControlClient which will be used to
abstract the logic for submitting queries to either a local or
remote admission controller out from ClientRequestState/Coordinator.
Currently only local submission is supported.
- SubmitForAdmission now takes a BackendId representing the
coordinator instead of assuming that the local impalad will be the
coordinator.
- The CRS_BEFORE_ADMISSION debug action is moved into
SubmitForAdmission() so that it will be executed on whichever daemon
is performing admission control rather than always on the
coordinator (needed for TestAdmissionController.test_cancellation).
- ShardedQueryMap is extended to allow keys to be either TUniqueId or
UniqueIdPB and Add(), Get(), and Delete() convenience functions are
added.
- Some utils related to seralizing Thrift objects into sidecars are
added.
Testing:
- Passed a run of existing core tests.
Change-Id: I7974a979cf05ed569f31e1ab20694e29fd3e4508
---
A be/src/rpc/sidecar-util.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/query-driver.cc
M be/src/runtime/query-driver.h
M be/src/scheduling/CMakeLists.txt
A be/src/scheduling/admission-control-client.cc
A be/src/scheduling/admission-control-client.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
A be/src/scheduling/local-admission-control-client.cc
A be/src/scheduling/local-admission-control-client.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M be/src/service/CMakeLists.txt
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/control-service.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
D be/src/service/query-driver-map.cc
D be/src/service/query-driver-map.h
M be/src/util/CMakeLists.txt
A be/src/util/sharded-query-map-util.cc
M be/src/util/sharded-query-map-util.h
M common/thrift/ImpalaService.thrift
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_restart_services.py
M tests/query_test/test_observability.py
29 files changed, 520 insertions(+), 237 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/16411/3
--
To view, visit http://gerrit.cloudera.org:8080/16411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7974a979cf05ed569f31e1ab20694e29fd3e4508
Gerrit-Change-Number: 16411
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
