Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 )
Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16411/2/be/src/rpc/sidecar-util.h File be/src/rpc/sidecar-util.h: http://gerrit.cloudera.org:8080/#/c/16411/2/be/src/rpc/sidecar-util.h@83 PS2, Line 83: Status > I don't think so - Expected() is for common errors (which this shouldn't be Ok, that makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/16411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7974a979cf05ed569f31e1ab20694e29fd3e4508 Gerrit-Change-Number: 16411 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 28 Sep 2020 16:27:41 +0000 Gerrit-HasComments: Yes
