Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 )
Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr ...................................................................... Patch Set 1: (2 comments) Thanks for doing this, nice to see so much code deleted. http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/codegen/llvm-codegen-test.cc@176 PS1, Line 176: // TODO: Should we remove this completely? It is only used in CodegenInnerLoop; if we : // modify the loop to take an int64_t* as a parameter instead, we can achieve the same : // without embedding pointers in the IR. > This is something we should decide before merging this. Seems like a good thing to clean up if it's not too much work. http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/exprs/scalar-fn-call.cc@335 PS1, Line 335: RETURN_IF_ERROR > Here we propagate the error instead of wrapping the interpreted function co This change makes sense to me. I don't think we're depending on the old behaviour. -- To view, visit http://gerrit.cloudera.org:8080/16517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a06fbf23629a90cc2cca164176a89e557c7c4 Gerrit-Change-Number: 16517 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2020 21:54:39 +0000 Gerrit-HasComments: Yes
