Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 )
Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/16517/1/be/src/codegen/llvm-codegen-test.cc@176 PS1, Line 176: // IR for the generated linner loop: : // define void @JittedInnerLoop(i64* %counter) { : // entry: > Seems like a good thing to clean up if it's not too much work. Done -- To view, visit http://gerrit.cloudera.org:8080/16517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a06fbf23629a90cc2cca164176a89e557c7c4 Gerrit-Change-Number: 16517 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2020 10:50:06 +0000 Gerrit-HasComments: Yes
