Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16517 )
Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr ...................................................................... IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr LlvmCodeGen::CastPtrToLlvmPtr embeds a pointer that points to data in the current process's memory into codegen'd IR code. Our long term goal is to share the codegen'd IR among processes working on the same fragment, which is not possible if the IR contains pointers pointing to data of a specific process. A step in making the IR independent of the process generating it is removing LlvmCodeGen::CastPtrToLlvmPtr. Change-Id: I046a06fbf23629a90cc2cca164176a89e557c7c4 Reviewed-on: http://gerrit.cloudera.org:8080/16517 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/text-converter.cc M be/src/exprs/scalar-expr-ir.cc M be/src/exprs/scalar-expr.cc M be/src/exprs/scalar-expr.h M be/src/exprs/scalar-fn-call.cc M testdata/llvm/test-loop.cc 10 files changed, 62 insertions(+), 216 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I046a06fbf23629a90cc2cca164176a89e557c7c4 Gerrit-Change-Number: 16517 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
