Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16548 )
Change subject: IMPALA-10219: Add query option to simulate HDFS listing delay ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/16548/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/16548/1/be/src/service/query-options.h@223 PS1, Line 223: SIMULATE_CATALOGD_HDFS_LISTING_DELAY_MS, TQueryOptionLevel::ADVANCED) \ line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2284 PS1, Line 2284: public TCatalogObject reloadTable(Table tbl, TResetMetadataRequest request, String reason) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2309 PS1, Line 2309: long simulatedHdfsDelayMs = request.getSimulate_catalogd_hdfs_listing_delay_ms(); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1146 PS1, Line 1146: storageMetadataLoadTime_ += updateUnpartitionedTableFileMd(client, simulatedDelay); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1236 PS1, Line 1236: private long updateUnpartitionedTableFileMd(IMetaStoreClient client, long simulatedDelay) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/16548/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@80 PS1, Line 80: ValidWriteIdList writeIdList, ValidTxnList validTxnList, long simulateDelay, String logPrefix) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py File tests/custom_cluster/test_topic_update_frequency.py: http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@12 PS1, Line 12: from multiprocessing.pool import ThreadPool flake8: F401 'multiprocessing.pool.ThreadPool' imported but unused http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@14 PS1, Line 14: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@15 PS1, Line 15: import threading flake8: F401 'threading' imported but unused http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@18 PS1, Line 18: from time import sleep flake8: F401 'time.sleep' imported but unused http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@20 PS1, Line 20: from tests.beeswax.impala_beeswax import ImpalaBeeswaxException flake8: F401 'tests.beeswax.impala_beeswax.ImpalaBeeswaxException' imported but unused http://gerrit.cloudera.org:8080/#/c/16548/1/tests/custom_cluster/test_topic_update_frequency.py@47 PS1, Line 47: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/16548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7196b1ce76415a5faf3fa8575a26d22b2bf50b1 Gerrit-Change-Number: 16548 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Oct 2020 00:16:24 +0000 Gerrit-HasComments: Yes
