Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16548 )
Change subject: IMPALA-10219: Add query option to simulate HDFS listing delay ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16548/2//COMMIT_MSG@10 PS2, Line 10: SIMULATE_CATALOGD_HDFS_LISTING_DELAY_MS > Couldn't we use DEBUG_ACTION in the frontend similarly to delay/failure inj Thanks for this suggestion. I was not aware of this and will look into this. Definitely looks like a good match which can be enhanced to other RPC delays (HMS, Ranger etc) and the catalog service. http://gerrit.cloudera.org:8080/#/c/16548/2/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/16548/2/be/src/util/backend-gflag-util.cc@89 PS2, Line 89: DECLARE_int64(catalog_simulate_hdfs_listing_delay_ms); > What is the relation of the query option and the flag? I ran through the co yes, originally, I had created this as catalog service configuration which was being picked in the code during initialization of CatalogServiceCatalog. I think this can be removed. I will update the patch. http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py File tests/custom_cluster/test_topic_update_frequency.py: http://gerrit.cloudera.org:8080/#/c/16548/2/tests/custom_cluster/test_topic_update_frequency.py@24 PS2, Line 24: CustomClusterTestSuite > Does this has to be a custom cluster test? I agree that this should be a se This change was done to simulate certain conditions for development of patch for IMPALA-6671 (https://gerrit.cloudera.org/#/c/16549/) The test which uses this option in that patch is a custom cluster test. It looks like with debug actions though, we may have to keep this as a custom cluster test, right? -- To view, visit http://gerrit.cloudera.org:8080/16548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7196b1ce76415a5faf3fa8575a26d22b2bf50b1 Gerrit-Change-Number: 16548 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Oct 2020 20:38:33 +0000 Gerrit-HasComments: Yes
