wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 )
Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) ...................................................................... Patch Set 1: (3 comments) Thanks for this new feature, some small nits http://gerrit.cloudera.org:8080/#/c/16545/1/be/src/exec/output-partition.h File be/src/exec/output-partition.h: http://gerrit.cloudera.org:8080/#/c/16545/1/be/src/exec/output-partition.h@25 PS1, Line 25: needed Needed? http://gerrit.cloudera.org:8080/#/c/16545/1/common/thrift/Descriptors.thrift File common/thrift/Descriptors.thrift: http://gerrit.cloudera.org:8080/#/c/16545/1/common/thrift/Descriptors.thrift@54 PS1, Line 54: struct TIcebergColumnDescriptor { : 1: required i32 fieldId : } Maybe some comment here? If this struct just contains fieldId, why not just use i32 in TColumnDescriptor? http://gerrit.cloudera.org:8080/#/c/16545/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16545/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@213 PS1, Line 213: String tableLoc = feIcebergTable.getLocation(); : HadoopTables tables = IcebergUtil.getHadoopTables(); These two variables not been used in this method. -- To view, visit http://gerrit.cloudera.org:8080/16545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5690fb6c2cc51f0033fa26caf8597c80a11bcd8e Gerrit-Change-Number: 16545 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 06 Oct 2020 09:45:28 +0000 Gerrit-HasComments: Yes
