Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 )
Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) ...................................................................... Patch Set 1: (3 comments) So far. I only checked the tests. I'll come back later for the rest :) http://gerrit.cloudera.org:8080/#/c/16545/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test: http://gerrit.cloudera.org:8080/#/c/16545/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test@12 PS1, Line 12: date_string_col STRING, Should't this be DATE type instead to check coverage for that as well? 'string_col' already covers STRING. http://gerrit.cloudera.org:8080/#/c/16545/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test@23 PS1, Line 23: date_string_col You can convert this to date like CAST(date_string_col as date FORMAT 'MM/DD/YY') http://gerrit.cloudera.org:8080/#/c/16545/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-insert.test@172 PS1, Line 172: row_regex:'$NAMENODE/test-warehouse/$DATABASE/hadoop_catalog_test/test/custom_db/int_table/data/.*.0.parq','.*','' As I see there is no such test where you insert multiple times into a table and then query the table. Do you think it would make sense? E.g. after multiple insert checking a "SELECT *" and a "SHOW FILES" -- To view, visit http://gerrit.cloudera.org:8080/16545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5690fb6c2cc51f0033fa26caf8597c80a11bcd8e Gerrit-Change-Number: 16545 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 14 Oct 2020 12:42:34 +0000 Gerrit-HasComments: Yes
